← Back to team overview

kicad-developers team mailing list archive

More wxString multi-threading issues

 

Jon is currently fighting another wxString multi-threading issue.  Having done quite a few of these myself, I feel for him.

A lot of them were threaded accesses to globals, so it was easy enough to make the globals std::strings.  However, this one is EDA_TEXT’s m_Text field.  That’s going to be a pretty big change to move to std::string.  And it’s nearly impossible to compartmentalise because returning a const& isn’t really const (iterating over the string will modify the linked-list of iterators, which is where the trouble comes in).

What about moving Kicad to UTF16 internally?  (The linked list of iterators is a performance optimisation specifically for UTF8 builds.)

Follow ups