ac100 team mailing list archive

[Marc Dietrich <marvin24@xxxxxx>]

On Sunday 23 October 2011 16:18:56 Pierre-Hugues Husson wrote:
> Le dimanche 23 octobre 2011 13:01:38, Leon Romanovsky a écrit :
> > On Sun, Oct 23, 2011 at 04:13, Pierre-Hugues Husson <phhusson@xxxxxxxxx>
> 
> wrote:
> > > +       {
> > > +               //Resume on home key press
> > > +               char cmd[]={ 0x05, 0x03, 0x01, 0x02};
> > > +               cmd[2]=!!wakeup_on_home_key;
> > > +               nvec_write_async(nvec, cmd, sizeof(cmd));
> > > +       }
> > > +}
> > 
> > It is better to use the same coding style as was already in nvec
> > nvec_write_async(nvec, cmd, sizeof(cmd)); ===> nvec_write_async(nvec,
> > "\x05\x03\x01\x02", 4);
> 
> So the code would look like:
> if(wakeup_on_home_key)
> 	nvec_write_async(nvec, "\x05\x03\x01\x02", 4);
> else
> 	nvec_write_async(nvec, "\x05\x03\x00\x02", 4);
> ?
> I find it less understandable (as in which field is of which use).
> But well, all nvec code is mostly about magic code, so why not.

well, we want to convert these to some macro generated string in the future. 
So using a common way to do it makes it easier to convert later on I think. 
Julian proposed something like this:

21:56 < juliank> #define NVEC_CALL(nvec, type, subtype, payload...) \
21:56 < juliank> ({ \
21:56 < juliank> 	char buf[] = {NVEC_##type, NVEC_##type##_##subtype, 
payload}; \
21:56 < juliank> 	nvec_write_async((nvec), buf, sizeof(buf)); \
21:56 < juliank> })

Marc