ac100 team mailing list archive
Mailing list archive
Re: [PATCH] ASoC: alc5632: free hp gpio on module unload
Leon Romanovsky <leon@xxxxxxx>
Marc Dietrich <marvin24@xxxxxx>
Sun, 22 Jan 2012 12:53:47 +0100
KMail/4.7.3 (Linux/3.2.0-10-generic; KDE/4.7.3; x86_64; ; )
On Sunday 22 January 2012 12:25:05 Leon Romanovsky wrote:
> On Sun, Jan 22, 2012 at 12:01, Marc Dietrich <marvin24@xxxxxx> wrote:
> > This checks if the gpio is valid and frees it during unload of the
> > codec module.
> > Signed-off-by: Marc Dietrich <marvin24@xxxxxx>
> > ---
> > Hi Andrey, Leon,
> > attached patch fixes an issure seen by Paul Ferster on IRC (oops after
> > module
> > unload/reload and hp jack pluged in).
> > sound/soc/tegra/tegra_alc5632.c | 40
> > ++++++++++++++++++++------------------
> > (...)
> Hi Mark,
> Please, can you specify the branch you based your patch? The 3.0 doesn't
> have such code.
it is based on my chromeos-ac100-3.0 tree. Both chromeos-ac100-3.0 and
chromeos-ac100-3.0-exp contain this patch and also the patch from Andrey he
> It is too different from upstream and my 3.0 branch.
It seems you removed hp jack support from your version, maybe because you use
this branch for upstreaming.
I told Andrey on IRC already that it would be nice to create two public
branches for sound. One is based on my "stable" chromos-ac100-3.0 tree and
will receive fixes for users to enjoy (like the two latest patches) and one for
upstream (maybe based on asoc or linux-next). The latter one does not need to
be public, but it makes reviewing easier if you are interested.
What do you think?