← Back to team overview

ac100 team mailing list archive

Re: [PATCH 3/3] ARM: tegra: paz00: enable nvec keyboard support


On 07/19/2013 02:47 AM, Andrey Danin wrote:
> Signed-off-by: Andrey Danin <danindrey@xxxxxxx>

(Some patch descriptions would be useful)

> diff --git a/board/compal/dts/tegra20-paz00.dts b/board/compal/dts/tegra20-paz00.dts

> +	nvec {
> +		compatible = "nvidia,tegra20-nvec";
> +		reg = <0x7000c500 0x100>;
> +		clock-frequency = <80000>;
> +		request-gpios = <&gpio 170 0>; /* gpio PV2 */
> +		slave-addr = <138>;
> +	};

I would rather not propagate this DT binding. We need to fix the binding
to clearly separate the concepts of:

a) The I2C slave controller (which should be a standalone driver for the
Tegra I2C slave HW).

b) The protocol sent over the I2C slave channel (which would be specific
to NVEC, implement the GPIO hand-shaking, etc.).

c) The devices that communicate over the protocol (keyboard in this case).

I suspect we need separate DT nodes/sub-nodes for all of those, and a
method of hooking them all together.

Follow ups