ac100 team mailing list archive

[Andrey Danin <danindrey@xxxxxxx>]

Tom, thanks for the quick response.

Пятница, 19 июля 2013, 9:28 -07:00 от Tom Warren <TWarren@xxxxxxxxxx>:
> Andrey,
> 
...
> > ---
> >  arch/arm/include/asm/arch-tegra/tegra_nvec.h       |  117 +++++
> >  .../arm/include/asm/arch-tegra/tegra_nvec_events.h |   31 ++
> >  .../include/asm/arch-tegra/tegra_nvec_keyboard.h   |   36 ++
> >  .../include/asm/arch-tegra/tegra_nvec_keytable.h   |  313 +++++++++++++
> 
> I think some of these header files could be reduced / combined - do we really need this many header files in common arch-tegra for NVEC kbd support?
> 
> >  board/nvidia/common/board.c                        |   12 +
> >  drivers/i2c/Makefile                               |    1 +
> >  drivers/i2c/tegra_nvec.c                           |  462 ++++++++++++++++++++
> >  drivers/i2c/tegra_nvec_keyboard.c                  |  108 +++++
> 
> Shouldn't all input drivers (keyboard, etc.) go in driver/input/?
> 
Yes. NVEC have problems with early initialization and this is why
I kept some keyboard code in i2c driver. I spent some time to
implement delayed initialization. So it is possible, I will send
updated version later.

> > +++ b/arch/arm/include/asm/arch-tegra/tegra_nvec_events.h
...
> > +int nvec_read_events(void);
> 
> For instance, combine this file with tegra_nvec.h and tegra_nvec_keyboard.h into one file, tegra_nvec.h.
> And all protos should have their arguments spelled out in a header, as you did for nvec_do_request above.
> 
Will do.

Thanks for the review.