← Back to team overview

ac100 team mailing list archive

Re: [U-Boot] [PATCH 3/3] ARM: tegra: paz00: enable nveckeyboardsupport


On Tuesday 23 July 2013 08:40:42 Stephen Warren wrote:
> On 07/22/2013 01:09 AM, Marc Dietrich wrote:

[ snip the stuff we agreed upon ]

> > The nvec still needs to tell the slave driver which protocol to use, but
> > that can be hard coded.
> I'm not sure what that means. At the controller/HW level, aren't I2C and
> SMBUS the same; it's just the data within the transactions that may be
> more defined by one or the other?

at this level yes, but we need to handle the underlying protocol in the ISR, 
which means that depending on the protocol (smbus or I2C), we need a different 
interrupt service routine. Currently we are doing most of the smbus protocol 
in the ISR because of timing reasons and I'm not sure if we can change this. 
We are already suffering from nvec timeouts and I fear that splitting the 
protocol out of the ISR would make things even worse.

I'm going to submit a new DT binding during the weekend. Meanwhile, Andrey is 
trying to split the uboot driver in the hw and nvec parts and also adapting it 
for the new binding.


Follow ups