ac100 team mailing list archive

Thread
Date

Re: [PATCH 1/2] staging/nvec: Do not pass resource to mfd_add_devices()

To: Thierry Reding <thierry.reding@xxxxxxxxx>
From: Marc Dietrich <Marc.Dietrich@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 29 Jul 2014 22:23:17 +0200
Cc: devel@xxxxxxxxxxxxxxxxxxxx, Julian Andres Klode <jak@xxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, ac100@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1406632575-26075-1-git-send-email-thierry.reding@gmail.com>
User-agent: KMail/4.13.2 (Linux/3.13.0-32-generic; KDE/4.13.2; x86_64; ; )

Am Dienstag 29 Juli 2014, 13:16:14 schrieb Thierry Reding:
> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> The mfd_add_devices() function takes a struct resource * as fifth
> argument, but the nvec driver passes in a void __iomem *. The driver
> gets away with it because none of the subdevices ever directly access
> the registers.
> 
> Since subdevices never need to access the registers we can simply pass
> NULL instead.
> 
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>

Acked-by: Marc Dietrich <marvin24@xxxxxx>

> ---
>  drivers/staging/nvec/nvec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 0a5c84ad3f41..815065837ce7 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -893,7 +893,7 @@ static int tegra_nvec_probe(struct platform_device
> *pdev) }
> 
>  	ret = mfd_add_devices(nvec->dev, -1, nvec_devices,
> -			      ARRAY_SIZE(nvec_devices), base, 0, NULL);
> +			      ARRAY_SIZE(nvec_devices), NULL, 0, NULL);
>  	if (ret)
>  		dev_err(nvec->dev, "error adding subdevices\n");