ac100 team mailing list archive

Thread
Date

Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues

To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
From: Marc Dietrich <marvin24@xxxxxx>
Date: Mon, 17 Dec 2018 20:48:04 +0100 (CET)
Cc: devel@xxxxxxxxxxxxxxxxxxxx, Amir Mahdi Ghorbanian <indigoomega021@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, ac100@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20181217081640.GA16368@kroah.com>
User-agent: Alpine 2.21 (OSX 202 2017-01-01)


Hi,

On Mon, 17 Dec 2018, Greg KH wrote:

On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote:

@@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
 		break;
 	case 2:		/* first byte after command */
 		if (status == (I2C_SL_IRQ | RNW | RCVD)) {
-			udelay(33);
+			usleep_range(0, 33);


Why is this a valid range to sleep for for this device?  Have you been
able to verify/test this?

oh no, not again. Why does this come up again every half year? This udelayis a workaround for a hw bug which only seldom triggers (if it triggers atall). Secondly, this is in interrupt context, so *sleep timers are no go,afaik.


Marc