ac100 team mailing list archive

Thread
Date

Re: [PATCH] staging: nvec: paz00: remove unneeded call to platform_set_drvdata()

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
From: Marc Dietrich <marvin24@xxxxxx>
Date: Sun, 20 Aug 2023 22:47:54 +0200 (CEST)
Cc: Andrei Coardos <aboutphysycs@xxxxxxxxx>, gregkh@xxxxxxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, alex@xxxxxxxxxxx, ac100@xxxxxxxxxxxxxxxxxxx
In-reply-to: <fb1cc561-926e-478d-a6ce-9d97fa0dd0e1@kadam.mountain>
Ui-outboundreport: notjunk:1;M01:P0:ZfxN4xRr7iQ=;tyMI1esC88vfMqYJR6jampCCJ7+ fC6f0Lg1nzc2allvz3NVzvgVr3SeVr/ZS37ykwuHMqwFBD24RxzGWyb/P8kYFyd48YWosah86 ewlewQxEyWWXPRgk3v+Cc8Ou/0su1u+N7AOSOg34AKeJK9bQjUh+XzV3XYvWU9YAlyJdaeXEC azoCC2NeZ1IX3FP1UN1OjmllQ6opNFh+gPRUa6P3X14dJ4eq82hoZzsVU/OgqR6cZF4krGsSd uaObR2AHge+ENQJMXUGoQ0+JgflUCRSs1BvXQvhI7s6h7aOpmZgw9m2WjNC+OuJDX4jGJak5H besPx7qTFvqNsppg9CnZhGWyWRpQN0r3+TlS1aRmX8N2HeCd3o8enOgDYhF0IhoI1hIzQeoPB YZSGsPzLA/bU9jAfhqS40CjPTa8lncDh0byKdW7n9NDFrBkF2UNgalKAHV4BNK/cjX5pi3MSr FHnJG/RLgeWAELyYTfk0VyvnGNfAQOooXRj5XHY4uTJEeYYeNpYh4V6ibyqXlWkig0pZ/tGiY Q3g8mapx9M+h3ZwMBNPji8Og5gcmLqEMMP0cxkNkb/xiByukR7VwTsN14nTVeI+o5dylSFpTf AKNK2n5bD69rY4riq/0IePo5vQpiyChEPrIGMEYxSmoMtBSXkox0Rr7YgEjeOUtb/JtMo79sP zlVQiB0hPPSeK47oqRd73xXB3tl6QwGa6T0FVa6h0xZS4zaNjUndxybRJpjhowGXcqb9ekY9A lgnBSntB0TPuIU2zOCOQk7lHMgqDqqabYSFWqtaTs7EQMRoDk753bJX7mxlcpRJNwPfvH5TzI 7lPIFDglOMe4vRiDp8wjb+q3zEMqPrEWUvXNY7qCTcw79+4EGc9bX/kmtiNv3WJQc6afss8Bd cdpHfO7p67Ve9+Wxc/WU8gBLwzhgnOSFkUUNkoNh/Bwde1OvHocHmB608chO0cWy8j651TOMc AanymQ==

Hi,

On Thu, 10 Aug 2023, Dan Carpenter wrote:

On Wed, Aug 09, 2023 at 06:42:11PM +0300, Andrei Coardos wrote:

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
---


I think you are right, but why are we doing this?  That one line is
hardly a huge eyesore.  It's all risk and no reward.


I guess this was placed in order to implement a module unload function,
but this was never done. The driver also seems to have found another
method to get its private data, so this can be safely removed.

Have you tested this change on real hardware?


I just checked that it compiles and works on my AC100.

Thanks!

Marc