← Back to team overview

account-payment-team team mailing list archive

Re: lp:~elbati/account-payment/adding_account_voucher_cash_basis_7 into lp:account-payment/7.0

 

Review: Needs Fixing code review, no test

Nitpicking:

* line 72-74: please wrap at 80 cols
* line 198: use key in res rather than res.has_key(key)
* line 209 and 210: s/len(res.keys())/len(res)

apart from that LGTM
-- 
https://code.launchpad.net/~elbati/account-payment/adding_account_voucher_cash_basis_7/+merge/159379
Your team Account Payment is subscribed to branch lp:account-payment/7.0.


Follow ups

References