account-payment-team team mailing list archive
-
account-payment-team team
-
Mailing list archive
-
Message #00251
Re: [Merge] lp:~agilebg/account-payment/adding_account_due_list_7 into lp:account-payment/7.0
Review: Needs Fixing code review, no tests
Hello Alex,
Here are some little things you should fixes before we can merge your contribution:
missing context propagation in browse and search method at:
l.121
l.123
l.138
l.148
l.228
Please add a Contributors section in __openerp__.py description
l.218 in fields_view_get context default value should be None instead of {}
Otherwise LGTM thanks for your contrib!
Cheers
--
https://code.launchpad.net/~agilebg/account-payment/adding_account_due_list_7/+merge/182330
Your team Account Payment is subscribed to branch lp:account-payment/7.0.
References