account-payment-team team mailing list archive

["Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>]

Review: Needs Information

Hi,

first of all, I completely understand that you need the exportfunctionality without the account_banking backend.

Having that said, your approach involves a huge duplication of code, which inevitably leads to a duplictation of effort in maintaining this code.

Would it not be possible instead, to refactor acocunt_banking_payment_export so that it can be used without the payment mode type (it seems to me that this is the main change in this proposal), or come to a shared solution between account_banking and account_payment_extension with regards to the functionality that payment.mode.type provides?

Wrt the debit functionality, things are a little more complicated. It seems that you do copy the workflow changes, and even the account_banking interface to trigger the workflow transitions, but these methods are not called anywhere (e.g. debit_storno() in line 979). Can you clarify the use of this?

-- 
https://code.launchpad.net/~acysos-team/account-payment/account-payment-sepa-7.0/+merge/203211
Your team Account Payment is subscribed to branch lp:account-payment/7.0.