account-payment-team team mailing list archive
-
account-payment-team team
-
Mailing list archive
-
Message #00334
Re: [Merge] lp:~icsergio/account-payment/commercial-year-payment into lp:account-payment
Review: Needs Information
Ciao Sergio,
this is very similar to
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
I slightly prefer the Nicola's module, just because it use an explicit field 'months' and thus it is a little more clear.
But your module has tests so it got more points :-) But the tests can be easily adapted to account_payment_term_month
What do you think?
--
https://code.launchpad.net/~icsergio/account-payment/commercial-year-payment/+merge/210700
Your team Account Payment is requested to review the proposed merge of lp:~icsergio/account-payment/commercial-year-payment into lp:account-payment.
Follow ups
References