aesthete-team team mailing list archive

[Phil Weir <phil.t.weir@xxxxxxxxxxxxxx>]

[Sorry, didn't CC the list (also updated the wget comment)]

> <Snip log>
>
> You'll probably want to update README.txt noting how to install these third
> party packages. An automatic download may catch someone by surprise, but it
> should be sufficient to say that it does this in the documentation. Of
> course we don't necessarily need the automatic download if the files are
> already there, or manually placed there, so maybe an option to setup.py
> could be added to enable this functionality would be nice.
>
> My aim at this point is to get RPMs working, so since SyntaxHighlighter
> doesn't appear to be available in Fedora I'll have a go at making an RPM for
> that.
>
> Chris.
>

Agreed - that sounds like a plan. Perhaps a quick-fix, simple option
would be for setup.py to test for existence of SyntaxHighlighter in
the share tree and, now that we know it won't break other
functionality, issue a warning along the lines of
* SyntaxHighlighter missing : run "scripts/install_thirdparty.[sh or
py]" to install thirdparty components, then rerun setup.py
with some explanation in the readme.
install_thirdparty.sh could be something as simple as
========
 rm -rf share/html/thirdparty/SyntaxHighlighter
 wget http://alexgorbatchev.com/SyntaxHighlighter/download/download.php?sh_current
-O share/html/thirdparty/SyntaxHighlighter.zip
 cd share/html/thirdparty
 unzip SyntaxHighlighter.zip
 mv syntaxhighlighter_* SyntaxHighlighter
 rm SyntaxHighlighter.zip
 cd ../../..
========
and a test at the start to make sure we are in the right directory?

Alternatively, I'm noticing that there is a hosted version at that
website, and since the presentation version only contains the
pre-rendered content, that may be sufficient? That would just require
the extra script links in the code, which would be redundant if
SyntaxHighlighter is present locally.

Regarding the GTK header file deps - as you pointed out previously,
they should be pulled in by pygtk-devel. Actually, this functionality
is the only remaining reason for GTK-2 dependencies to be in there,
but that's another story. For reference, my suggestion was, firstly,
checking the pkgconfig response when the Extension is being added in
setup.py to see whether the `pkg-config gtk+-2.0` call complained,
omitting the extension module if so and, secondly, to test for the
existence of '_aesthete_c' in the Lantern.py import (the only place it
is currently being imported) and prevent 'Lantern.get_paste' from
calling 'get_svg_from_clipboard' if so.
P