aims team mailing list archive
-
aims team
-
Mailing list archive
-
Message #01736
[Bug 1311056] Re: apt-add-repository adds duplicate commented/disabled source lines
Analysis *before* situation: The loop after the __find call did not
really match the __find call before - it was looking only for non-
disabled sources, but then had an if case for disabled ones to enable
them if the components match - which was never reached.
Now, I think the patch is slightly wrong: The if case is reachable now,
so it would enable an existing disabled source even if we passed
disabled=True. The for loop thus needs 4 cases now, the existing ones
corresponding to disabled=False and two variants of them for
disabled=True (might be possible to write with less cases).
--
You received this bug notification because you are a member of AIMS,
which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1311056
Title:
apt-add-repository adds duplicate commented/disabled source lines
Status in python-apt package in Ubuntu:
Triaged
Status in software-properties package in Ubuntu:
Triaged
Bug description:
Trusty Tahr 14.04
0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list
deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
# deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop
gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created
gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created
gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com
gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created
gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported
gpg: Total number processed: 1
gpg: imported: 1 (RSA: 1)
OK
0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
# deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
# deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
0 root@osprey:/etc/apt/sources.list.d#
That deb-src line should have stayed commented out, and not been
duplicated. (Commented deb lines should of course be uncommented, as
already fixed per https://bugs.launchpad.net/ubuntu/+source/python-
apt/+bug/1042916 .)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions