aims team mailing list archive

[Łukasz Zemczak <1311056@xxxxxxxxxxxxxxxxxx>]

Hello Jan, or anyone else affected,

Accepted python-apt into xenial-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/python-
apt/1.1.0~beta1ubuntu0.16.04.9 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
xenial to verification-done-xenial. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-xenial. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

-- 
You received this bug notification because you are a member of AIMS,
which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1311056

Title:
  [SRU] apt-add-repository adds duplicate commented/disabled source
  lines

Status in python-apt package in Ubuntu:
  Fix Released
Status in python-apt source package in Xenial:
  Fix Committed
Status in python-apt source package in Bionic:
  Fix Committed
Status in python-apt source package in Eoan:
  Fix Committed

Bug description:
  Impact
  ======

  Under most circumstances, the impact is minimal (a few extra redundant
  comment lines in apt sources. However, if users are automating source
  removal / addition on a machine (as in comment 11), there is the
  potential to wind up with an excessively large (and thus slow to
  parse) apt sources configuration.

  Test packages for the supported releases are available from the
  following PPA:

  https://launchpad.net/~waveform/+archive/ubuntu/python-apt

  Built from the source which can be found in the following branches:

  https://code.launchpad.net/~waveform/ubuntu/+source/python-apt/+git
  /python-apt/+ref/sru-dupe-ppa-xenial

  https://code.launchpad.net/~waveform/ubuntu/+source/python-apt/+git
  /python-apt/+ref/sru-dupe-ppa-bionic

  https://code.launchpad.net/~waveform/ubuntu/+source/python-apt/+git
  /python-apt/+ref/sru-dupe-ppa-eoan

  Test Case
  =========

  * sudo add-apt-repository -y ppa:deadsnakes/ppa
  * cat /etc/apt/sources.list.d/deadsnakes*.list
  * Note the presence of one uncommented "deb" line, and one commented "deb-src" line
  * sudo add-apt-repository -y ppa:deadsnakes/ppa
  * cat /etc/apt/sources.list.d/deadsnakes*.list
  * Note the uncommented "deb" line is still there but the commented "deb-src" line has now been duplicated
  * sudo add-apt-repository ppa:waveform/python-apt
  * sudo apt upgrade  # update python-apt to fixed version
  * sudo add-apt-repository -y ppa:deadsnakes/ppa
  * cat /etc/apt/sources.list.d/deadsnakes*.list
  * Note there has been no further duplication of the commented "deb-src" line

  Regression Potential
  ====================

  Minimal; test cases have been added to cover the duplication case, and
  to cover the enabling of sources (which was not covered by existing
  tests, but was part of the code altered to fix the duplication case),
  and insertion of sources at a position (again, not covered by existing
  tests but modified as part of the fix). The test case has been used
  successfully on all targeted releases (xenial, bionic, and eoan).

  Original Description
  ====================

  Trusty Tahr 14.04

  0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list
  deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
  # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
  0 root@osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop
  gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created
  gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created
  gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com
  gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created
  gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported
  gpg: Total number processed: 1
  gpg:               imported: 1  (RSA: 1)
  OK
  0 root@osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
  # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
  # deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
  0 root@osprey:/etc/apt/sources.list.d#

  That deb-src line should have stayed commented out, and not been
  duplicated. (Commented deb lines should of course be uncommented, as
  already fixed per https://bugs.launchpad.net/ubuntu/+source/python-
  apt/+bug/1042916 .)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-apt/+bug/1311056/+subscriptions