anewt-developers team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 1691
committer: Wouter Bolsterlee <uws@xxxxxxxxx>
branch nick: anewt.uws
timestamp: Mon 2009-07-20 21:45:56 +0200
message:
  [database] Simplify freeing result sets in MySQL backend
  
  There is no need for an explicit state kept in $freed.
modified:
  database/backend-mysql.lib.php

=== modified file 'database/backend-mysql.lib.php'
--- database/backend-mysql.lib.php	2009-07-19 19:42:51 +0000
+++ database/backend-mysql.lib.php	2009-07-20 19:45:56 +0000
@@ -156,11 +156,6 @@
  */
 class AnewtDatabaseResultSetMySQL extends AnewtDatabaseResultSet
 {
-	/**
-	 * Whether the result set has been freed.
-	 */
-	private $freed = false;
-
 	/* 
 	 * The methods below implement/override AnewtDatabaseConnection methods.
 	 */
@@ -179,7 +174,7 @@
 
 	function fetch_one()
 	{
-		if ($this->freed)
+		if (!$this->result_set_handle)
 			return null;
 
 		$row = $this->result_set_handle->fetch_assoc();
@@ -203,7 +198,6 @@
 
 		$this->result_set_handle->free();
 		$this->result_set_handle = null;
-		$this->freed = true;
 	}
 
 	/* Type deducing and row casting */



--
lp:anewt
https://code.launchpad.net/~uws/anewt/anewt.uws

Your team Anewt developers is subscribed to branch lp:anewt.
To unsubscribe from this branch go to https://code.launchpad.net/~uws/anewt/anewt.uws/+edit-subscription.