anewt-developers team mailing list archive

[Wouter Bolsterlee <uws@xxxxxxxxx>]

Hi, see below...

2009-07-20 klockan 22:47 skrev noreply@xxxxxxxxxxxxx:
> ------------------------------------------------------------
> revno: 1472
> committer: Sander van Schouwenburg <sander@xxxxxxxxxxxxx>
> branch nick: anewt.new.cxs
> timestamp: Mon 2009-07-20 17:53:59 +0200
> message:
>   [form] Fixed bug with simple text required markers.
>   
>   The marker was cloned to prevent problems with DOM nodes, but this does not
>   work for simple text markers. A check is performed to see whether we need to
>   clone the marker.
>   
>   
>   (from anewt.new.svn:81)
> modified:
>   form/renderer/default.lib.php
> 
> === modified file 'form/renderer/default.lib.php'
> --- form/renderer/default.lib.php	2009-04-07 17:07:47 +0000
> +++ form/renderer/default.lib.php	2009-07-20 15:53:59 +0000
> @@ -153,7 +153,9 @@
>  
>  			if ($this->get('required-marker') && $control->get('required'))
>  			{
> -				$marker = clone $this->get('required-marker');
> +				$marker = $this->get('required-marker');
> +				if (is_object($marker))
> +					$marker = clone $marker;
>  				$control_div->append_child($marker);
>  			}
>  			unset ($label);

I think that

  if ($marker instanceof AnewtXMLDomNode)
      $marker = clone $marker;

... would be cleaner.

    — Wouter

Attachment: signature.asc
Description: Digital signature