apport-hackers team mailing list archive

[Philip Muškovac <yofel@xxxxxxx>]

Philip Muškovac has proposed merging lp:~yofel/apport/pathname_completion_fix into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)


When putting the code for the parameterless completion together I missed that 'ubuntu-bug /bin/bash' is allowed and reused the code I used for '-c', so right now
ubuntu-bug /bin/ba<tab> 
does nothing. 
The change here makes it complete any file again.
-- 
https://code.launchpad.net/~yofel/apport/pathname_completion_fix/+merge/28320
Your team Apport upstream developers is requested to review the proposed merge of lp:~yofel/apport/pathname_completion_fix into lp:apport.

=== modified file 'etc/bash_completion.d/apport_completion'
--- etc/bash_completion.d/apport_completion	2010-04-14 14:32:17 +0000
+++ etc/bash_completion.d/apport_completion	2010-06-23 18:35:58 +0000
@@ -25,13 +25,12 @@
     #        package names
     #        PIDs
     #        Symptoms
-    #        .crash/.apport files
+    #        any file
     param="$dashoptions \
            $( apt-cache pkgnames $cur 2> /dev/null ) \
            $( command ps axo pid | sed 1d ) \
            $( _apport_symptoms ) \
-           $( compgen -G "${cur}*.apport"
-              compgen -G "${cur}*.crash" )"
+           $( compgen -G "${cur}*" )"
     COMPREPLY=( $( compgen -W "$param" -- $cur) )
 
 }