apport-hackers team mailing list archive

[Javier Collado <javier.collado@xxxxxxxxxxxxx>]

Javier Collado has proposed merging lp:~javier.collado/apport/ordered_symptoms into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)


This is a small change to order symptoms description before showing them to the user.

"Other problem" options isn't ordered so it remains being the last one in the dialog.
-- 
https://code.launchpad.net/~javier.collado/apport/ordered_symptoms/+merge/38567
Your team Apport upstream developers is requested to review the proposed merge of lp:~javier.collado/apport/ordered_symptoms into lp:apport.

=== modified file 'apport/ui.py'
--- apport/ui.py	2010-10-09 22:51:02 +0000
+++ apport/ui.py	2010-10-15 16:34:42 +0000
@@ -519,6 +519,10 @@
         if not symptom_names:
             return False
 
+        symptom_descriptions, symptom_names = \
+            zip(*sorted(zip(symptom_descriptions, symptom_names)))
+        symptom_descriptions = list(symptom_descriptions)
+        symptom_names = list(symptom_names)
         symptom_names.append(None)
         symptom_descriptions.append('Other problem')