apport-hackers team mailing list archive

[Philip Muškovac <yofel@xxxxxxx>]

Philip Muškovac has proposed merging lp:~yofel/apport/lp-765808 into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)
Related bugs:
  Bug #765808 in apport (Ubuntu): "apport doesn't use the default browser"
  https://bugs.launchpad.net/ubuntu/+source/apport/+bug/765808

For more details, see:
https://code.launchpad.net/~yofel/apport/lp-765808/+merge/58501

kfmclient is part of konqueror which isn't shipped in kubuntu by default anymore since we use rekonq now. Apport should use kde-open to open URLs instead which is part of kdebase-runtime and shipped by default.
-- 
https://code.launchpad.net/~yofel/apport/lp-765808/+merge/58501
Your team Apport upstream developers is requested to review the proposed merge of lp:~yofel/apport/lp-765808 into lp:apport.

=== modified file 'apport/ui.py'
--- apport/ui.py	2011-03-31 15:23:04 +0000
+++ apport/ui.py	2011-04-20 14:33:28 +0000
@@ -877,12 +877,12 @@
 
         # figure out appropriate web browser
         try:
-            # if ksmserver is running, try kfmclient
+            # if ksmserver is running, try kde-open
             try:
                 if os.getenv('DISPLAY') and \
                         subprocess.call(['pgrep', '-x', '-u', str(uid), 'ksmserver'],
                                 stdout=subprocess.PIPE, stderr=subprocess.PIPE) == 0:
-                    subprocess.call(sudo_prefix + ['kfmclient', 'openURL', url])
+                    subprocess.call(sudo_prefix + ['kde-open', url])
                     sys.exit(0)
             except OSError:
                 pass