apport-hackers team mailing list archive

[Brian Murray <brian@xxxxxxxxxx>]

Brian Murray has proposed merging lp:~brian-murray/apport/package-segfaul into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)

For more details, see:
https://code.launchpad.net/~brian-murray/apport/package-segfaul/+merge/65967

If a package installation failure is due to a segfault don't report the bug as we really want the crash report.
-- 
https://code.launchpad.net/~brian-murray/apport/package-segfaul/+merge/65967
Your team Apport upstream developers is requested to review the proposed merge of lp:~brian-murray/apport/package-segfaul into lp:apport.

=== modified file 'data/general-hooks/generic.py'
--- data/general-hooks/generic.py	2011-06-12 19:07:37 +0000
+++ data/general-hooks/generic.py	2011-06-27 11:36:34 +0000
@@ -76,6 +76,10 @@
     if '/usr/lib/libGL.so' in (report.get('StacktraceTop') or '\n').splitlines()[0] \
         and 'Loading extension GLX' not in apport.hookutils.read_file('/var/log/Xorg.0.log'):
             report['UnreportableReason'] = 'The X.org server does not support the GLX extension, which the crashed program expected to use.'
+    # filter out package install failures due to a segfault
+    if 'Segmentation fault' in report['ErrorMessage'] \
+        and report['ProblemType'] == 'Package':
+            report['UnreportableReason'] = 'The package installation resulted in a segmentation fault which is better reported as a crash report rather than a package install failure.'
 
 
 if __name__ == '__main__':