apport-hackers team mailing list archive

[Evan Dandrea <evan.dandrea@xxxxxxxxxxxxx>]

Evan Dandrea has proposed merging lp:~ev/apport/disable-core-removal into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)

For more details, see:
https://code.launchpad.net/~ev/apport/disable-core-removal/+merge/81974

Martin presumably needs a dataset of core files to verify his work on the crash signature.  I need this same data to test the load on various parts of the crash database implementation.

The proposed branch disables removal of core files from bug reports.
-- 
https://code.launchpad.net/~ev/apport/disable-core-removal/+merge/81974
Your team Apport upstream developers is requested to review the proposed merge of lp:~ev/apport/disable-core-removal into lp:apport.

=== modified file 'apport/crashdb_impl/launchpad.py'
--- apport/crashdb_impl/launchpad.py	2011-11-01 19:55:36 +0000
+++ apport/crashdb_impl/launchpad.py	2011-11-11 12:19:31 +0000
@@ -410,14 +410,7 @@
                     bug = self.launchpad.bugs[id]
                     break
 
-        # remove core dump if stack trace is usable
         if report.has_useful_stacktrace():
-            for a in bug.attachments:
-                if a.title == 'CoreDump.gz':
-                    try:
-                        a.removeFromBug()
-                    except HTTPError:
-                        pass # LP#249950 workaround
             try:
                 task = self._get_distro_tasks(bug.bug_tasks).next()
                 task.importance = 'Medium'
@@ -636,9 +629,9 @@
                     return
             
             for a in bug.attachments:
-                if a.title in ('CoreDump.gz', 'Stacktrace.txt',
-                    'ThreadStacktrace.txt', 'Dependencies.txt', 'ProcMaps.txt',
-                    'ProcStatus.txt', 'Registers.txt', 'Disassembly.txt'):
+                if a.title in ('Stacktrace.txt', 'ThreadStacktrace.txt',
+                    'Dependencies.txt', 'ProcMaps.txt', 'ProcStatus.txt',
+                    'Registers.txt', 'Disassembly.txt'):
                     try:
                         a.removeFromBug()
                     except HTTPError:
@@ -721,13 +714,6 @@
             task.lp_save()
             bug.newMessage(content=invalid_msg,
                     subject='Crash report cannot be processed')
-            
-            for a in bug.attachments:
-                if a.title == 'CoreDump.gz':
-                    try:
-                        a.removeFromBug()
-                    except HTTPError:
-                        pass # LP#249950 workaround
         else:
             if 'apport-failed-retrace' not in bug.tags:
                 bug.tags = bug.tags + ['apport-failed-retrace'] # LP#254901 workaround