← Back to team overview

apport-hackers team mailing list archive

[Merge] lp:~brian-murray/apport/bug-1039220 into lp:apport

 

Brian Murray has proposed merging lp:~brian-murray/apport/bug-1039220 into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)
Related bugs:
  Bug #1039220 in apport (Ubuntu): "don't report crashes for programs that don't match the file on disk (like for kernel crashes)"
  https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1039220

For more details, see:
https://code.launchpad.net/~brian-murray/apport/bug-1039220/+merge/123196

We actually don't want to send crash reports where the binary changed since the crash occurred to the crash database right now as it causes confusion as to whether or not a bug is really fixed.

When testing this I noticed that in this particular case the crash file is not updated and there is no UnreportableReason key / value pair in the bug report.  I wonder if that would be a useful thing to do.

I'm happy to write a test case for this scenario but wasn't sure which test would be the best one to use.
-- 
https://code.launchpad.net/~brian-murray/apport/bug-1039220/+merge/123196
Your team Apport upstream developers is requested to review the proposed merge of lp:~brian-murray/apport/bug-1039220 into lp:apport.
=== modified file 'apport/ui.py'
--- apport/ui.py	2012-08-24 10:31:13 +0000
+++ apport/ui.py	2012-09-06 23:48:23 +0000
@@ -280,7 +280,12 @@
             if not response['report']:
                 return
 
-            apport.fileutils.mark_report_upload(report_file)
+            # We don't want to send crashes to the crash database for binaries
+            # that changed since the crash happened. See LP: #1039220 for
+            # details.
+            if not 'changed since the crash occurred' in \
+                    self.report['UnreportableReason']:
+                apport.fileutils.mark_report_upload(report_file)
             # We check for duplicates and unreportable crashes here, rather
             # than before we show the dialog, as we want to submit these to the
             # crash database, but not Launchpad.


Follow ups