apport-hackers team mailing list archive

[James Hunt <james.hunt@xxxxxxxxxxxxx>]

James Hunt has proposed merging lp:~jamesodhunt/apport/report-ld-variables into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)

For more details, see:
https://code.launchpad.net/~jamesodhunt/apport/report-ld-variables/+merge/147049

  * apport/report.py: report if LD_PRELOAD and LD_LIBRARY_PATH set
    (but don't divulge values).

It's useful to know if these two variables are set since they can impact program behaviour.
-- 
https://code.launchpad.net/~jamesodhunt/apport/report-ld-variables/+merge/147049
Your team Apport upstream developers is requested to review the proposed merge of lp:~jamesodhunt/apport/report-ld-variables into lp:apport.

=== modified file 'apport/report.py'
--- apport/report.py	2013-01-04 12:48:54 +0000
+++ apport/report.py	2013-02-07 09:35:25 +0000
@@ -577,6 +577,14 @@
                         if self['ProcEnviron']:
                             self['ProcEnviron'] += '\n'
                         self['ProcEnviron'] += 'XDG_RUNTIME_DIR=<set>'
+                elif l.startswith('LD_PRELOAD='):
+                        if self['ProcEnviron']:
+                            self['ProcEnviron'] += '\n'
+                        self['ProcEnviron'] += 'LD_PRELOAD=<set>'
+                elif l.startswith('LD_LIBRARY_PATH='):
+                        if self['ProcEnviron']:
+                            self['ProcEnviron'] += '\n'
+                        self['ProcEnviron'] += 'LD_LIBRARY_PATH=<set>'
 
     def add_kernel_crash_info(self, debugdir=None):
         '''Add information from kernel crash.