apport-hackers team mailing list archive
-
apport-hackers team
-
Mailing list archive
-
Message #00163
[Merge] lp:~brian-murray/apport/bug-1316841 into lp:apport
Brian Murray has proposed merging lp:~brian-murray/apport/bug-1316841 into lp:apport.
Requested reviews:
Apport upstream developers (apport-hackers)
Related bugs:
Bug #1316841 in apport (Ubuntu): "apportcheckresume does not create a duplicate signature"
https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1316841
For more details, see:
https://code.launchpad.net/~brian-murray/apport/bug-1316841/+merge/219038
suspend resume failures have no duplicate signature so aren't bucketed in the error tracker. This fixes that by using report.crash_signature().
--
https://code.launchpad.net/~brian-murray/apport/bug-1316841/+merge/219038
Your team Apport upstream developers is requested to review the proposed merge of lp:~brian-murray/apport/bug-1316841 into lp:apport.
=== modified file 'NEWS'
--- NEWS 2014-05-06 05:59:20 +0000
+++ NEWS 2014-05-09 17:33:05 +0000
@@ -5,6 +5,8 @@
-------------------
* Add kernel package version to the various kernel-related hooks. Thanks Brian
Murray.
+ * Add a duplicate signature to suspend resume failures. Thanks Brian Murray.
+ (LP: #1316841)
2.14.2 (2014-04-30)
-------------------
=== modified file 'data/apportcheckresume'
--- data/apportcheckresume 2014-04-29 17:41:29 +0000
+++ data/apportcheckresume 2014-05-09 17:33:05 +0000
@@ -10,7 +10,6 @@
# the full text of the license.
import os
-import os.path
import sys
import datetime
@@ -83,7 +82,9 @@
if pr.check_ignored():
return 0
-
+ crash_signature = pr.crash_signature()
+ if crash_signature:
+ pr['DuplicateSignature'] = crash_signature
nowtime = datetime.datetime.now()
pr_filename = '/var/crash/susres.%s.crash' % (str(nowtime).replace(' ', '_'))
with os.fdopen(os.open(pr_filename, os.O_WRONLY | os.O_CREAT | os.O_EXCL, 0o640), 'wb') as report_file: