apport-hackers team mailing list archive

[Brian Murray <brian@xxxxxxxxxx>]

Brian Murray has proposed merging lp:~brian-murray/apport/remove-checkresume-dupesig into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)

For more details, see:
https://code.launchpad.net/~brian-murray/apport/remove-checkresume-dupesig/+merge/219861

The duplicate signature was actually incomplete and missing information as 'MachineType' is not known to apport when apportcheckresume is run, rather this information is gathered by the apport package hook for linux so the duplicate signature creation belongs there.

You can see the incomplete signatures in the error tracker:

https://errors.ubuntu.com/oops/73891a08-dc8d-11e3-94de-fa163e707a72

-- 
https://code.launchpad.net/~brian-murray/apport/remove-checkresume-dupesig/+merge/219861
Your team Apport upstream developers is requested to review the proposed merge of lp:~brian-murray/apport/remove-checkresume-dupesig into lp:apport.

=== modified file 'NEWS'
--- NEWS	2014-05-14 20:58:42 +0000
+++ NEWS	2014-05-16 15:24:18 +0000
@@ -5,8 +5,6 @@
 -------------------
  * Add kernel package version to the various kernel-related hooks. Thanks Brian
    Murray. (LP: #1316845)
- * Add a duplicate signature to suspend resume failures. Thanks Brian Murray.
-   (LP: #1316841)
  * Use package name in duplicate signature for recoverable problems. Thanks Brian
    Murray. (LP: #1316763)
  * Have whoopsie-upload-all upload recoverable problems. Thanks Brian Murray.

=== modified file 'data/apportcheckresume'
--- data/apportcheckresume	2014-05-09 17:35:01 +0000
+++ data/apportcheckresume	2014-05-16 15:24:18 +0000
@@ -83,10 +83,6 @@
         if pr.check_ignored():
             return 0
 
-        crash_signature = pr.crash_signature()
-        if crash_signature:
-            pr['DuplicateSignature'] = crash_signature
-
         nowtime = datetime.datetime.now()
         pr_filename = '/var/crash/susres.%s.crash' % (str(nowtime).replace(' ', '_'))
         with os.fdopen(os.open(pr_filename, os.O_WRONLY | os.O_CREAT | os.O_EXCL, 0o640), 'wb') as report_file: