apport-hackers team mailing list archive

[Brian Murray <brian@xxxxxxxxxx>]

Brian Murray has proposed merging lp:~brian-murray/apport/attribute-error-with-value-error into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)

For more details, see:
https://code.launchpad.net/~brian-murray/apport/attribute-error-with-value-error/+merge/238190

This fixes the following Traceback.
https://errors.ubuntu.com/problem/d7b8b576c9b773cd5d822e833534e98fba85e30d

Traceback (most recent call last):
  File "/usr/share/apport/recoverable_problem", line 41, in main
    report.add_proc_info(report.pid)
  File "/usr/lib/python3/dist-packages/apport/report.py", line 513, in add_proc_info
    raise ValueError('invalid process')
ValueError: invalid process

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/share/apport/recoverable_problem", line 75, in <module>
    main()
  File "/usr/share/apport/recoverable_problem", line 44, in main
    if e.message == 'invalid process':
AttributeError: 'ValueError' object has no attribute 'message'

I'm going to upload it directly to Utopic too.
-- 
https://code.launchpad.net/~brian-murray/apport/attribute-error-with-value-error/+merge/238190
Your team Apport upstream developers is requested to review the proposed merge of lp:~brian-murray/apport/attribute-error-with-value-error into lp:apport.

=== modified file 'data/recoverable_problem'
--- data/recoverable_problem	2014-10-10 12:08:15 +0000
+++ data/recoverable_problem	2014-10-13 16:32:38 +0000
@@ -41,7 +41,7 @@
         report.add_proc_info(report.pid)
     except ValueError as e:
         # The process may have gone away before we could get to it.
-        if e.message == 'invalid process':
+        if 'invalid process' == e.args[0]:
             return
 
     # Get the info on the bug