apport-hackers team mailing list archive

[Stéphane Graber <stgraber@xxxxxxxxxxxx>]

The proposal to merge lp:~stgraber/apport/bug1445064 into lp:apport has been updated.

Description changed to:

This is the implemented of https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1445064

The original implementation of this feature was a security nightmare and had to be reverted. This new design should be safe as the host will never actually execute any code, just contact a pre-existing apport setup and forward the crash to it.

The receiving end of this is made of a systemd socket and systemd service, this binds /run/apport.socket (root owned, 0600 permission) and on connection to it, spawns the main apport script. I modified the apport script to detect systemd's environment variables, replace stdin by the connection fd and replace sys.argv by the arguments sent over the socket.

The sending part simply uses the existing container check, then checks if /run/apport.socket exists in the container. If it does, it connects to it, sends the arguments and then sends sys.stdin through.

For more details, see:
https://code.launchpad.net/~stgraber/apport/bug1445064/+merge/283752
-- 
Your team Apport upstream developers is requested to review the proposed merge of lp:~stgraber/apport/bug1445064 into lp:apport.