apport-hackers team mailing list archive

[Brian Murray <brian@xxxxxxxxxx>]

Brian Murray has proposed merging lp:~brian-murray/apport/external-core-file into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)

For more details, see:
https://code.launchpad.net/~brian-murray/apport/external-core-file/+merge/310601

apport-retrace can take a --core-file option which will point to an external file which is a core dump for retracing, however apport-retrace reads that file and adds it to the report object which is inefficient.  Instead we can just set the CoreDump key to a file path and pass that to gdb_command which already supports this. Briefly:

        if 'CoreDump' in self:
            if hasattr(self['CoreDump'], 'find'):
            ...
            else:
                # value is a file path
                core = self['CoreDump'][0]

-- 
Your team Apport upstream developers is requested to review the proposed merge of lp:~brian-murray/apport/external-core-file into lp:apport.

=== modified file 'bin/apport-retrace'
--- bin/apport-retrace	2015-09-24 12:19:28 +0000
+++ bin/apport-retrace	2016-11-11 00:06:58 +0000
@@ -266,8 +266,7 @@
                  options.report)
 
 if options.core_file:
-    with open(options.core_file, 'rb') as f:
-        report['CoreDump'] = f.read()
+    report['CoreDump'] = (os.path.abspath(options.core_file),)
 if options.executable:
     report['ExecutablePath'] = options.executable
 if options.procmaps: