← Back to team overview

apport-hackers team mailing list archive

Re: [Merge] lp:~mwhudson/apport/regexp-raw-strings into lp:apport

 

I ran the apport tests and encountered an error from pyflakes.

Diff comments:

> 
> === modified file 'test/test_signal_crashes.py'
> --- test/test_signal_crashes.py	2016-12-10 11:28:27 +0000
> +++ test/test_signal_crashes.py	2017-06-12 23:45:56 +0000
> @@ -485,7 +485,7 @@
>          self.assertFalse('CoreDump' in pr)
>          # FIXME: sometimes this is empty!?
>          if err:
> -            self.assertRegex(err, b'core dump exceeded.*dropped from .*yes\..*\.crash')
> +            self.assertRegex(err, rb'core dump exceeded.*dropped from .*yes\..*\.crash')

This seems to have raised an error with pyflakes:

 $ test/run
Testing local source tree.
Running pycodestyle...
Running pyflakes...
./test/test_signal_crashes.py:488:87: invalid syntax
            self.assertRegex(err, rb'core dump exceeded.*dropped from .*yes\..*\.crash')

>  
>      def test_ignore(self):
>          '''ignoring executables'''


-- 
https://code.launchpad.net/~mwhudson/apport/regexp-raw-strings/+merge/325543
Your team Apport upstream developers is requested to review the proposed merge of lp:~mwhudson/apport/regexp-raw-strings into lp:apport.


References