apport-hackers team mailing list archive

[Brian Murray <brian@xxxxxxxxxx>]

Sorry about the diff being mangled, I've added an inline comment about the change required for pyflakes - hopefully that makes things clearer. I'll just fix it myself though so no extra work is required.

Diff comments:

> 
> === modified file 'test/test_signal_crashes.py'
> --- test/test_signal_crashes.py	2016-12-10 11:28:27 +0000
> +++ test/test_signal_crashes.py	2017-06-14 23:43:07 +0000
> @@ -485,7 +485,8 @@
>          self.assertFalse('CoreDump' in pr)
>          # FIXME: sometimes this is empty!?
>          if err:
> -            self.assertRegex(err, b'core dump exceeded.*dropped from .*yes\..*\.crash')
> +            self.assertRegex(
> +                err, rb'core dump exceeded.*dropped from .*yes\..*\.crash')

The fix required here, for pyflakes, is to remove the b and use two "\" instead of one. I'll just fix this when I merge it.

>  
>      def test_ignore(self):
>          '''ignoring executables'''


-- 
https://code.launchpad.net/~mwhudson/apport/regexp-raw-strings/+merge/325543
Your team Apport upstream developers is requested to review the proposed merge of lp:~mwhudson/apport/regexp-raw-strings into lp:apport.