apport-hackers team mailing list archive

[Didier Roche <didrocks@xxxxxxxxxx>]

Didier Roche has proposed merging lp:~didrocks/apport/handle-older-reports into lp:apport.

Requested reviews:
  Apport upstream developers (apport-hackers)

For more details, see:
https://code.launchpad.net/~didrocks/apport/handle-older-reports/+merge/354692

Handle older reports without the remember key.

Old reports (generated pre-apport 2.20.10-0ubuntu4) may not have the remember key
and can be loaded afterwards (or after dist-upgrade), and thus, trigger a KeyError.
Consider it as false then.
Use try/expect for python2 support.
Fixes LP: #1791324
-- 
Your team Apport upstream developers is requested to review the proposed merge of lp:~didrocks/apport/handle-older-reports into lp:apport.

=== modified file 'apport/ui.py'
--- apport/ui.py	2018-06-25 16:23:29 +0000
+++ apport/ui.py	2018-09-11 11:38:34 +0000
@@ -305,8 +305,13 @@
                 self.restart()
             if response['blacklist']:
                 self.report.mark_ignore()
-            if response['remember']:
-                self.remember_send_report(response['report'])
+            try:
+                if response['remember']:
+                    self.remember_send_report(response['report'])
+            # use try/expect for python2 support. Old reports (generated pre-apport 2.20.10-0ubuntu4)
+            # may not have the remember key and can be loaded afterwards (or after dist-upgrade)
+            except KeyError:
+                pass
             if not response['report']:
                 return