← Back to team overview

apt-zeroconf team mailing list archive

Re: Improving check-in quality

 

What up all,
    While not trying to speak for the crew that did the Sunday hack on
this a few weeks ago, I think the sense was that trunk needs much more
care and that personal/other team branches should see the action.
Broken trunk is always bad.

    I've been involved in projects where one person controls trunk, but
not where merges to trunk are done by peer review.  Is there a good
place to read about how that might be done?  And is there still a
"leader" who has final say?

    Adam


On Fri, Jul 10, 2009 at 12:46:06PM +1000, Neil Shepperd wrote:
> Hi list,
> 
> On Fri, 2009-07-10 at 02:03 +0100, Jorge O. Castro wrote:
> > Hey guys,
> > 
> > We have tests and DVCS, I've been struggling with trunk seeming to be
> > randomly broken at any given time and a general sense of "wild wild
> > west". What do you guys think about using the launchpad features to do
> > reviews? I was thinking something like making personal branches and
> > then submitting them to be merged into trunk via launchpad - then peer
> > review before merges. What do you think?
> 
> Sounds good. Something that might also be a good plan is to officially
> implement rule #1 of TDD: trunk should always pass tests. At least then
> the insanity will be slightly reduced. (also, I wonder if launchpad
> could get one of those automatic gatekeeper programs which refuse to
> push if one of the tests is broken by the change?)
> 
> Neil



Follow ups

References