arsenal-devel team mailing list archive

[Chris J Arges <chris.j.arges@xxxxxxxxxxxxx>]

Chris J Arges has proposed merging lp:~christopherarges/arsenal/arsenal into lp:arsenal.

Requested reviews:
  Bryce Harrington (bryce)

For more details, see:
https://code.launchpad.net/~christopherarges/arsenal/arsenal/+merge/99387

I'm introducing a few new items:
- search on subscribers for bugs in cbd
- search based on private_only bugs in cbd
- add base directory for SEG related reports

Thanks,
-- 
https://code.launchpad.net/~christopherarges/arsenal/arsenal/+merge/99387
Your team arsenal-devel is subscribed to branch lp:arsenal.

=== modified file 'reports/cbd'
--- reports/cbd	2012-03-13 20:58:18 +0000
+++ reports/cbd	2012-03-26 17:49:20 +0000
@@ -314,8 +314,23 @@
             assignees = ''
         Dbg.verbose('search: assignees: \'%s\'\n' % ','.join(assignees))
 
-        if assignees != '' and reporters != '':
-            print('You must choose either assignees or reporters not both!')
+        try:
+            subscribers = search_criteria['subscribers']
+        except KeyError:
+            subscribers = ''
+        Dbg.verbose('search: subscribers: \'%s\'\n' % ','.join(subscribers))
+
+	# ensure that only one of these are selected
+	count = 0
+        if assignees != '':
+		count += 1
+	if reporters != '':
+		count += 1
+	if subscribers != '':
+		count += 1
+
+	if count > 1:
+            print('You must choose either assignees, reporters or subscribers')
             exit(1)
 
         Dbg.leave("CollectBugData.distro_tasks_search")
@@ -359,6 +374,19 @@
                             modified_since=last_run_time):
                             tasks.append(task)
             return tasks
+	# Subscribers searches differently than assignee, participant. 
+	# TODO: consolidate searching by these fields and make the splitting team
+	# into participants a configurable feature.
+        if subscribers != '':
+            tasks = []
+            for subscriber in subscribers:
+                search_subscriber = self.lp.launchpad.people[subscriber]
+                for task in distro.search_tasks(tags=search_tags,
+                    tags_combinator=search_tags_combinator,
+                    status=search_status, bug_subscriber=search_subscriber,
+                    modified_since=last_run_time):
+                        tasks.append(task)
+            return tasks
         else:
             return distro.search_tasks(tags=search_tags,
                 tags_combinator=search_tags_combinator, status=search_status,
@@ -447,7 +475,9 @@
                                         recorded_bugs.remove(bug_number)
 
                                 try:
-                                    if not task.bug.private or self.cfg['show_private_bugs']:
+				    # TODO: perhaps we should move the show_private_bugs flag to a search_criteria option?
+				    if (sc['private_only'] and task.bug.private) or \
+				        (not sc['private_only'] and (not task.bug.private or self.cfg['show_private_bugs'])):
                                         t = self.get_task_info(task)
                                         t['debug']['series'] = s
                                         t_name = t['bug_target_name']
@@ -462,7 +492,7 @@
                                             iso_tasks[bug_number].append(t)
 
                                     else:
-                                        print("it's private (%s) http://pad.lv/%s"; % (bug_number, bug_number))
+                                        Dbg.verbose("Bug %s doesn't match visibility http://pad.lv/%s\n"; % (bug_number, bug_number))
                                 except HTTPError as e:
                                     print('Exception caught processing bug: %s' % bug_number)
                                     if 'x-lazr-oopsid' in e.response:

=== added directory 'reports/seg'
=== added file 'reports/seg/Makefile'
--- reports/seg/Makefile	1970-01-01 00:00:00 +0000
+++ reports/seg/Makefile	2012-03-26 17:49:20 +0000
@@ -0,0 +1,9 @@
+SEG_DASHBOARD = dash.html
+
+all: reports 
+reports: $(SEG_DASHBOARD)
+
+.PHONY: $(SEG_DASHBOARD)
+$(SEG_DASHBOARD) :
+	../cbd --debug="verbose" seg.json
+

=== added file 'reports/seg/seg.json'
--- reports/seg/seg.json	1970-01-01 00:00:00 +0000
+++ reports/seg/seg.json	2012-03-26 17:49:20 +0000
@@ -0,0 +1,23 @@
+{
+    "launchpad_config": {
+        "launchpad_client_name": "seg", 
+        "read_only": true
+    }, 
+    "search_criteria": [
+        {
+            "distribution": "ubuntu", 
+            "private_only": true, 
+            "status": [
+                "New", 
+                "Confirmed", 
+                "Triaged", 
+                "In Progress", 
+                "Fix Committed"
+            ], 
+            "subscribers": [
+                "canonical-support"
+            ]
+        }
+    ], 
+    "tasks": {}
+}