ayatana-commits team mailing list archive

["Neil J. Patel" <neil.patel@xxxxxxxxxxxxx>]

Review: Needs Information
Looks good. I had some suggestions/questions:

menuitem_get_properties_new_cb:
  - I'd normally check that data != NULL before accessing its members

menuitem_call_cb:
  - I'd, normally check that returned pointer from g_new0 != NULL

dbusmenu_client_add_type_handler:
  - Would a check for type!= NULL make sense here, as you use it to lookup in the hashtable?
  - Does newfunc need to also be checked? Or is is okay to add a NULL func (i.e. to unset a previously set function)?

new_item_seperator &  new_item_normal:
  - Are arg checks required for newitem, parent and client?

child_realized:
  - I'd have g_return_if_fail (DBUS_MENU_GTKMENU (userdata)) before casting it as its a signal callback


-- 
https://code.edge.launchpad.net/~ted/dbusmenu/types/+merge/10772
Your team ayatana-commits is subscribed to branch lp:dbusmenu.