ayatana-commits team mailing list archive

["Neil J. Patel" <neil.patel@xxxxxxxxxxxxx>]

Review: Approve
> > menuitem_call_cb:
> >   - I'd, normally check that returned pointer from g_new0 != NULL
> 
> Do you mean "parse_layout_xml"?  I believe that is the only call to
> g_new0 in client.c, fixed :)  (r35)
> 

yes :)

> > child_realized:
> >   - I'd have g_return_if_fail (DBUS_MENU_GTKMENU (userdata)) before casting
> it as its a signal callback
> 
> I used DBUSMENU_IS_GTKMENU, but yeah. (r38)

Thankfully one of us woke up this morning :)

Approved.
-- 
https://code.edge.launchpad.net/~ted/dbusmenu/types/+merge/10772
Your team ayatana-commits is subscribed to branch lp:dbusmenu.