← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~macslow/notify-osd/gravity into lp:notify-osd

 

Review: Approve
Thanks for putting that together quickly.

Remarks
- line 57: the comment is wrong (mentions a font size)
- it looks like the error rollback code could be factored into a helper function; but that's fine for a quick fix
- unit tests, good


-- 
https://code.edge.launchpad.net/~macslow/notify-osd/gravity/+merge/10963
Your team ayatana-commits is subscribed to branch lp:notify-osd.



Follow ups

References