ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

On Tue, 2009-09-01 at 15:13 +0000, Aurélien Gâteau wrote:
> I see the server parameter has been removed from the IndicatorAdded
>  and IndicatorRemoved signals. Does this mean the indicator id is 
> now globally unique?

It should be unique per server.  So the combination of the server dbus
ID and the indicator ID should yield a unique combination.

> There is a missing word in doc for INDICATE_INDICATOR_SIGNAL_DISPLAYED signal

Actually it was just really bad grammar :)  (r385)

> indicate_listener_default_max_indicators():
> typo in doc: effects => affects

Fixed.  (r386)

> I would have called this function indicate_listener_set_default_max_indicators() for consistency
>
> indicate_listener_server_max_indicators():
> I would have called this function indicate_listener_server_set_max_indicators()

Fixed.  (r387)

> Question: do we still need the concept of Interest?

Yes, we do need it for the server interest items.  It's less useful for
the items no for sure.  But, in theory we're not requiring setting a max
number of indicators (even infinite) so you could say that you're
interested without setting a value.  But, we could change that as well.

> And oh, indentation is really... creative

It's the only way to make tabstop be configurable :)


-- 
https://code.launchpad.net/~ted/libindicate/messages-v2/+merge/10954
Your team ayatana-commits is subscribed to branch lp:~ted/libindicate/messages-v2.