ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Review: Approve

In set_indicator_unread_count, generally I like to use g_strdup_printf
instead of g_sprintf because you don't have to choose how many character
it'll be.  But, you need to g_free it at the end.

I'd pull "unread" into a #define to just ensure that it's the same in
all places it's used.

In update_accounts timeval should probably be init'd with {0} instead of
{0,} as I think one will initialize all fields of the struct and the
other only the first.

In general, I consider all of these comments pretty minor.  Clean up
stuff, I'm going to mark the review as approved.  Cool!

  review approve

-- 
https://code.launchpad.net/~indicator-applet-developers/evolution-indicator/multiple-mailbox-indication/+merge/11464
Your team ayatana-commits is subscribed to branch lp:evolution-indicator.