← Back to team overview

ayatana-commits team mailing list archive

[Merge] lp:~ted/libindicate/listen-and-print-signals into lp:libindicate

 

Ted Gould has proposed merging lp:~ted/libindicate/listen-and-print-signals into lp:libindicate.

Requested reviews:
    Indicator Applet Developers (indicator-applet-developers)

Little fix to the signals for listen-and-print to match the new signal prototypes.  Love the type-safety of signals.
-- 
https://code.launchpad.net/~ted/libindicate/listen-and-print-signals/+merge/11630
Your team ayatana-commits is subscribed to branch lp:libindicate.
=== modified file 'examples/listen-and-print.c'
--- examples/listen-and-print.c	2009-08-03 23:01:06 +0000
+++ examples/listen-and-print.c	2009-09-09 17:43:33 +0000
@@ -57,9 +57,9 @@
 static void
 show_property (IndicateListener * listener, IndicateListenerServer * server, IndicateListenerIndicator * indicator, gchar * property)
 {
-	if (!strcmp(property, "icon")) {
+	if (!g_strcmp0(property, "icon")) {
 		indicate_listener_get_property_icon(listener, server, indicator, property, show_property_icon_cb, NULL);
-	} else if (!strcmp(property, "time")) {
+	} else if (!g_strcmp0(property, "time")) {
 		indicate_listener_get_property_time(listener, server, indicator, property, show_property_time_cb, NULL);
 	} else {
 		indicate_listener_get_property(listener, server, indicator, property, show_property_cb, NULL);
@@ -75,22 +75,22 @@
 }
 
 static void
-indicator_added (IndicateListener * listener, IndicateListenerServer * server, IndicateListenerIndicator * indicator, gchar * type, gpointer data)
+indicator_added (IndicateListener * listener, IndicateListenerServer * server, IndicateListenerIndicator * indicator, gpointer data)
 {
-	g_debug("Indicator Added:          %s %d %s", INDICATE_LISTENER_SERVER_DBUS_NAME(server), INDICATE_LISTENER_INDICATOR_ID(indicator), type);
+	g_debug("Indicator Added:          %s %d", INDICATE_LISTENER_SERVER_DBUS_NAME(server), INDICATE_LISTENER_INDICATOR_ID(indicator));
 	get_properties(listener, server, indicator);
 }
 
 static void
-indicator_removed (IndicateListener * listener, IndicateListenerServer * server, IndicateListenerIndicator * indicator, gchar * type, gpointer data)
+indicator_removed (IndicateListener * listener, IndicateListenerServer * server, IndicateListenerIndicator * indicator, gpointer data)
 {
-	g_debug("Indicator Removed:        %s %d %s", INDICATE_LISTENER_SERVER_DBUS_NAME(server), INDICATE_LISTENER_INDICATOR_ID(indicator), type);
+	g_debug("Indicator Removed:        %s %d", INDICATE_LISTENER_SERVER_DBUS_NAME(server), INDICATE_LISTENER_INDICATOR_ID(indicator));
 }
 
 static void
-indicator_modified (IndicateListener * listener, IndicateListenerServer * server, IndicateListenerIndicator * indicator, gchar * type, gchar * property, gpointer data)
+indicator_modified (IndicateListener * listener, IndicateListenerServer * server, IndicateListenerIndicator * indicator, gchar * property, gpointer data)
 {
-	g_debug("Indicator Modified:       %s %d %s %s", INDICATE_LISTENER_SERVER_DBUS_NAME(server), INDICATE_LISTENER_INDICATOR_ID(indicator), type, property);
+	g_debug("Indicator Modified:       %s %d %s", INDICATE_LISTENER_SERVER_DBUS_NAME(server), INDICATE_LISTENER_INDICATOR_ID(indicator), property);
 	show_property(listener, server, indicator, property);
 }
 


Follow ups