ayatana-commits team mailing list archive

[David Barth <david.barth@xxxxxxxxxxxxx>]

Review: Needs Fixing
The changes with the weak reference callback are good.

There is one spurious g_print to remove.

Also, you've commented out the code that acknowledges a notify-close call: it seems like a regression, you need to support closing bubbles programmatically, and avoid crashing if you try to do so on a bubble that doesn't exist anymore.
-- 
https://code.launchpad.net/~macslow/notify-osd/fix-427924/+merge/12281
Your team ayatana-commits is subscribed to branch lp:notify-osd.