ayatana-commits team mailing list archive

Thread
Date

Re: [Merge] lp:~ted/cape-girardeau/lib-flesh into lp:~ted/cape-girardeau/trunk

To: Cody Russell <crussell@xxxxxxxxxxxxx>
From: Ted Gould <ted@xxxxxxxx>
Date: Tue, 03 Nov 2009 17:06:14 -0000
In-reply-to: <20091103162712.24530.4107.codereview@palladium.canonical.com>
Reply-to: mp+13810@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

On Tue, 2009-11-03 at 16:27 +0000, Cody Russell wrote:
> 349	 static void
> 350	 custom_indicator_dispose (GObject *object)
> 351	 {
> 352	+	CustomIndicator * self = CUSTOM_INDICATOR(object);
> 353	+	g_return_if_fail(self != NULL);
> 354	+
> 355	+	CustomIndicatorPrivate * priv = CUSTOM_INDICATOR_GET_PRIVATE(self);
> 356	+	g_return_if_fail(priv != NULL);
> 
> Both of these NULL tests don't seem necessary in the dispose method.  Or in any of the other GObject methods here, like init, set_property, get_property, finalize.
> 
> Not really a big deal though, so I'll +1 this.

Fixed in r58.  Merging.

-- 
https://code.launchpad.net/~ted/cape-girardeau/lib-flesh/+merge/13810
Your team ayatana-commits is subscribed to branch lp:~ted/cape-girardeau/trunk.