← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~ted/indicator-applet/code-unification into lp:indicator-applet

 

Review: Approve
 review: approve

This is a clear reduction in duplicate code so +1. I'll note though that
it may be a little hard to scale up and work with vs structuring it as
some code with overridable helpers, or a set of callable trivial
functions. But that can be examined in future.

-Rob

-- 
https://code.launchpad.net/~ted/indicator-applet/code-unification/+merge/16809
Your team ayatana-commits is subscribed to branch lp:indicator-applet.



References