ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Review: Needs Information
On Mon, 2010-02-15 at 14:48 +0000, Aurélien Gâteau wrote:
> Make it possible to get the GValue for a property.

Oops, can't believe I forgot this.

> I also removed the return which prevented the property callback 
> from being called when there is an error (such as a missing 
> property) as it was preventing me using the library in this way:
> 
> - ask for property1
> - wait for callback
> - process property1 value
> - ask for property2
> ....

I'm worried that this will cause indeterminate results.  Do you think
that we should call the callback with "known" values in this case as the
value of GValue * is indeterminate if error is set?

I'm also worried that this might break a lot of applications who have
expected this behavior and don't handle errors in their callback.

  review needs-info


-- 
https://code.launchpad.net/~agateau/libindicate/gvalue/+merge/19336
Your team ayatana-commits is subscribed to branch lp:libindicate.