ayatana-commits team mailing list archive

["Neil J. Patel" <neil.patel@xxxxxxxxxxxxx>]

Review: Needs Fixing
- You could just send (GFunc)g_object_unref instead of having an explicit func_unref function to the g_list_foreach (though I see why you may not want to).

- I'd set priv->listener = NULL; after unreffing it, as you've done for the other properties in dispose

- When accessing AppMenuItem through `gpointer data` in callbacks, I'd do a g_return_if_fail (APP_IS_MENU_ITEM (data)) first, as the data arguments aren't "protected" during signal emission (e.g. ref, emit, unref for objects).
-- 
https://code.edge.launchpad.net/~ted/indicator-messages/dynamic-commands/+merge/19570
Your team ayatana-commits is subscribed to branch lp:indicator-messages.