← Back to team overview

ayatana-commits team mailing list archive

Re: lp:~cjcurran/indicator-sound/stable-service-with-unstable-pulse into lp:indicator-sound

 

Review: Needs Information
I'd like to see some unit tests that show how the code now handles corner cases properly, typically with pa not being available at startup, then appearing, the flipping ten times. Do you have a test environment that can simulate that situation?

To improve the readability of the merge proposals, can you also embed some emacs or vi tab setttings in your files?
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/stable-service-with-unstable-pulse/+merge/20224
Your team ayatana-commits is subscribed to branch lp:indicator-sound.



References