← Back to team overview

ayatana-commits team mailing list archive

Thread
Date

Re: [Merge] lp:~dbarth/indicator-me/display-mode-gconf-key into lp:indicator-me

To: David Barth <david.barth@xxxxxxxxxxxxx>
From: Ted Gould <ted@xxxxxxxx>
Date: Tue, 23 Mar 2010 18:49:24 -0000
In-reply-to: <20100323184319.30491.45767.launchpad@loganberry.canonical.com>
Reply-to: mp+21968@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information
I can't find where you're emitting the User Changed signal.  It seems like that should also be added into the DBus interface spec for the service.

Also, you need to add a GConf Schema for the GConf key.
-- 
https://code.edge.launchpad.net/~dbarth/indicator-me/display-mode-gconf-key/+merge/21968
Your team ayatana-commits is subscribed to branch lp:indicator-me.

References

[Merge] lp:~dbarth/indicator-me/display-mode-gconf-key into lp:indicator-me
From: David Barth, 2010-03-23