ayatana-commits team mailing list archive

[Conor Curran <conor.curran@xxxxxxxxxxxxx>]

Conor Curran has proposed merging lp:~cjcurran/indicator-sound/dbus-handle-event-crash into lp:indicator-sound.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  #521283 indicator-applet crashed with SIGSEGV in dbusmenu_menuitem_handle_event()
  https://bugs.launchpad.net/bugs/521283

-- 
https://code.launchpad.net/~cjcurran/indicator-sound/dbus-handle-event-crash/+merge/22221
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

=== modified file 'src/slider-menu-item.c'
--- src/slider-menu-item.c	2010-03-04 18:02:45 +0000
+++ src/slider-menu-item.c	2010-03-26 13:59:18 +0000
@@ -77,12 +77,14 @@
 }
 
 
-
 static void
 handle_event (DbusmenuMenuitem * mi, const gchar * name, const GValue * value, guint timestamp)
 {
 	g_debug("in the handle event method of slider_menu_item");
-    set_sink_volume((gdouble)g_value_get_double(value));
+    gdouble volume_input = 0;
+    volume_input = g_value_get_double(value);
+    if(value != NULL)
+        set_sink_volume(volume_input);
 }