← Back to team overview

ayatana-commits team mailing list archive

Thread
Date

Re: [Merge] lp:~bratsche/appmenu-gtk/almost-rewrite into lp:appmenu-gtk

To: Cody Russell <crussell@xxxxxxxxxxxxx>
From: Jason Smith <JasSmith@xxxxxxxxx>
Date: Tue, 15 Jun 2010 17:59:24 -0000
In-reply-to: <20100615150425.11547.76497.launchpad@loganberry.canonical.com>
Reply-to: mp+27638@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve
Looks good. Could use a couple comments explaining what happens in fail conditions here and there (like if your proxy is null) but nothing blocking a merge.

+1
-- 
https://code.launchpad.net/~bratsche/appmenu-gtk/almost-rewrite/+merge/27638
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.

References

[Merge] lp:~bratsche/appmenu-gtk/almost-rewrite into lp:appmenu-gtk
From: Cody Russell, 2010-06-15